Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.4 #301

Merged
merged 9 commits into from
Nov 30, 2024
Merged

v1.4.4 #301

merged 9 commits into from
Nov 30, 2024

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Nov 30, 2024

Description

Package

  • Updated github actions

Models

  • Updated net_regression()
    • It now works (better) with unweighted networks
    • Added print methods that combine tidy() and glance()
    • Fixed effect naming error
    • Updated same() to work for two-mode networks
    • Updated specification advice for testing for homophily in two-mode networks

Checklist:

  • Documentation
    • Any longer functions are commented inline so that it is easier to debug in the future
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Any closed, fixed, or related issues are referenced and described, e.g. "Fixed #0 by adding A"
  • PR checks all pass for latest commit
    • Package builds on my OS without issues
    • CodeFactor check: Package improves or maintains good style
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 39 lines in your changes missing coverage. Please review.

Project coverage is 47.45%. Comparing base (4d15f50) to head (ab2405d).
Report is 123 commits behind head on main.

Files with missing lines Patch % Lines
R/model_regression.R 16.21% 31 Missing ⚠️
R/class_models.R 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   49.46%   47.45%   -2.02%     
==========================================
  Files          27        5      -22     
  Lines        2347      569    -1778     
==========================================
- Hits         1161      270     -891     
+ Misses       1186      299     -887     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhollway jhollway merged commit 53a08f4 into main Nov 30, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant